dialog-link rendering issue#192
Closed
kafkasl wants to merge 2 commits into
Closed
Conversation
Contributor
|
I think better to figure out the underlying issue. PS: another reminder to at-mention me or add me as a reviewer please @kafkasl |
Contributor
Author
|
ok. I'll have a look. Sorry about the review request I'm aware of it, surprised I missed it again mb |
Contributor
|
@kafkasl bumping this |
Contributor
Author
it's in my TODO list but not very high in priority, do you prefer I close the PR (or set it to draft) while I don't work on it? The solution is probably not even close as it fixes the symptom rather than the underlying issue so most of this is useless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small quality of life improvement.
Before: Dialog link did not include the msg_id when present in the label (only in the link) that made the LLM add it with the weird issue that it becomes 2 separate links.
After:Adding it as a slash fixes it.
I assume it's some weird markdown rendering issue, I am not sure if it's not worth digging much deeper though than this small fix